-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for gMSA s3 test #3886
Merged
Merged
Fix for gMSA s3 test #3886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update NewS3Client * Updated mocks * Updated unit tests
Thanks for making this change! This not only helps our functional tests but also has customer facing value where their ECS container instance and credential spec s3 object are not in the same region. 🎉 |
singholt
previously approved these changes
Sep 21, 2023
singholt
reviewed
Sep 21, 2023
singholt
approved these changes
Sep 21, 2023
mythri-garaga
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gMSA Linux fetches task's credentialspec from an S3 location. The S3Client session was previously created with the instance's region assuming the instance and S3 region would be the same. This resulted in failure of GMSA functional Linux test in few regions. This change modifies NewS3Client to create S3Client session with S3 bucket region. This will allow functional GMSA Linux test to run in all regions, without creating region specific test buckets and objects.
Implementation details
Updated NewS3Client
Updated mocks
Updated unit tests
Testing
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.