Add interface for csi client #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjkon
reviewed
Sep 12, 2023
fierlion
approved these changes
Sep 12, 2023
mye956
approved these changes
Sep 12, 2023
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Sep 15, 2023
* Add interface for csi client * Add comments * Add comments
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Sep 20, 2023
* Add interface for csi client * Add comments * Add comments
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Sep 20, 2023
* Add interface for csi client * Add comments * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add an interface for the csi client which can be used by Agent to communicate with the CSI driver daemon.
Implementation details
GetVolumeMetricsNewCSIClientto return a pointer.Testing
New tests cover the changes: no
Description for the changelog
Add interface for csi client.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.