Bump cgroups and containernetworking/plugins version #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realmonia
force-pushed
the
useCgroupV3
branch
4 times, most recently
from
f2d8d68
to
ed2101a
Compare
Realmonia
changed the title
Realmonia
force-pushed
the
useCgroupV3
branch
from
ed2101a
to
eef6ad7
Compare
Realmonia
force-pushed
the
useCgroupV3
branch
from
eef6ad7
to
bc91c72
Compare
mythri-garaga
approved these changes
Sep 25, 2023
singholt
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps several dependency versions, most notably
github.com/containernetworking/pluginsfrom v0.9.1 to v1.1.1. This is to match current Fargate version to avoid incompatibility or behavior difference when integrate.github.com/containerd/cgroups/v3from v1.0.4 to v3.0.2git.luolix.top/containernetworking/pluginsv1.3.0 (latest) depends oncgroupsv1.1.0.cgroupsv1.1.0 which contains a fix to a bug in previous version, however the fix itself contains another bug and is fixed ingit.luolix.top/containerd/cgroups/v3v3.0.2. Note thatgit.luolix.top/containernetworking/pluginsonly requiresgit.luolix.top/containerd/cgroupsv1.0.4, However to avoid future breaks, we should just bump cgroups version higher.cgroups/V3contains a file structure change that needs some code change in agent integration with it. It is included in this PR.Implementation details
Testing
New tests cover the changes: N/A
Manually tested awsvpc mode works with plugin updates.
Description for the changelog
Bump cgroups and containernetworking/plugins version
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.