Add new network data structures #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new task level network data structure and a network namespace level data structure into the shared network library. This enables the path to having a unified network library for ECS data plane.
Realmonia
approved these changes
Sep 19, 2023
ubhattacharjya
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a new task level network data structure and a network
namespace level data structure into the shared network library. This
enables the path to having a unified network library for ECS data plane.
Implementation details
New data structures as agreed in design are added under the
ecs-agent/netlib/modelpackage.Testing
make testandmake run-integ-testspassed on local environment.New tests cover the changes: Yes
Passed Github workflow.
Description for the changelog
Add
TaskNetworkConfigandNetworkNamespacemodels to shared network library.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.