Process attachment payload message for EBS attach #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
changed the title
mye956
reviewed
Sep 15, 2023
mye956
reviewed
Sep 15, 2023
mye956
reviewed
Sep 15, 2023
mye956
reviewed
Sep 15, 2023
mye956
approved these changes
Sep 15, 2023
fierlion
reviewed
Sep 15, 2023
fierlion
approved these changes
Sep 15, 2023
danehlim
approved these changes
Sep 19, 2023
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Sep 20, 2023
* Process attachment payload message for EBS attach * Add one more test case * Update agent * Update amazonebs to AmazonElasticBlockStorage * Save attachmentType
xxx0624
added a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Sep 20, 2023
* Process attachment payload message for EBS attach * Add one more test case * Update agent * Update amazonebs to AmazonElasticBlockStorage * Save attachmentType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to update the current attachment payload process to support the
AttachmentTypefor EBS attach which will useAmazonElasticBlockStorageas the attachment type specifically.AmazonElasticBlockStorageis the only one we support so far and all other attachment types will be ignored.Implementation details
AttachmentTypeis added to the existingResourceAttachment.AttachmentTypefrom ACS and verify all required properties are present.Testing
New tests cover the changes: yes
Description for the changelog
Feature - support AttachmentType for the attachment payload for EBS Attach
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.