Add default wait timeout for attachments from ACS #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
changed the title
xxx0624
force-pushed
the
dev
branch
2 times, most recently
from
48a9fa3
to
4b163c3
Compare
xxx0624
changed the title
xxx0624
force-pushed
the
dev
branch
2 times, most recently
from
1802ee7
to
f9c4128
Compare
samjkon
reviewed
Sep 20, 2023
| @@ -194,7 +205,7 @@ func validateAttachmentAndReturnProperties(message *ecsacs.ConfirmAttachmentMess | |||
| return attachmentProperties, nil | |||
| } | |||
|
|
|||
| // For "EphemeralStorage" and "ElasticBlockStorage", ACS is using resourceType to indicate its attachment type. | |||
| // For legacy EBS volumes("EphemeralStorage" and "ElasticBlockStorage"), ACS is using resourceType to indicate its attachment type. | |||
There was a problem hiding this comment.
nit: For my understanding, is it appropriate referring to these storage means as legacy? Are we planning to deprecate them at any point already?
There was a problem hiding this comment.
Are we planning to deprecate them at any point already?
I don't think so. I think we will continue to support both but won't change them much.
I will confirm with @fierlion since this comment is from this PR https://github.com/aws/amazon-ecs-agent/pull/3911/files/9597f968e447852d88a3fb7d75a7a550fba24ffb#r1327869451
There was a problem hiding this comment.
non-blocking: My comment's intent was to remove the words EphemeralStorage altogether. This is a nit but we should follow up and fix this comment.
samjkon
approved these changes
Sep 20, 2023
mye956
approved these changes
Sep 21, 2023
fierlion
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a default wait timeout for handling attachment payload message from ACS if no waitTimeout is provided in the message. This can protect Agent from waiting for the attachment ready forever.
Implementation details
Add a the default wait timeout in
attachment_resource_responderwhen processing the attachment payload message.Testing
New tests cover the changes: no
Description for the changelog
Enhancement - add a default wait timeout for attachment payload messages.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.