Add missing changes from EBS Task Attach feature branch #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
force-pushed
the
fierlion/devEbsFix
branch
3 times, most recently
from
8c26ec1
to
2c37049
Compare
fierlion
force-pushed
the
fierlion/devEbsFix
branch
from
2c37049
to
f68119c
Compare
mye956
reviewed
Oct 13, 2023
mye956
reviewed
Oct 13, 2023
fierlion
force-pushed
the
fierlion/devEbsFix
branch
4 times, most recently
from
8b64c00
to
78b0072
Compare
fierlion
changed the title
mye956
reviewed
Oct 13, 2023
amogh09
reviewed
Oct 13, 2023
mye956
reviewed
Oct 13, 2023
| @@ -203,6 +203,52 @@ func TestAddPendingEBSAttachment(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| func TestAddPendingEBSAttachmentExclusion(t *testing.T) { | |||
There was a problem hiding this comment.
nit: perhaps we can add a comment on what this will be testing for. a bit unclear on what we mean by exclusion here
fierlion
force-pushed
the
fierlion/devEbsFix
branch
from
f39241d
to
7a0d116
Compare
mye956
approved these changes
Oct 16, 2023
amogh09
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change bridges the diff between dev and https://github.com/aws/amazon-ecs-agent/tree/feature/EBSTaskAttach
The main changes are to add the EBS resource handler to the agent, and to update the watcher's state handling.
Implementation details
The changes came from a rebase of the feature branch against dev, taking dev as desired. The changes to the watcher and to the task engine state include a couple of bugfixes to our EBS state handling, where previously there was a chance that a notification came before a successful NodeStage.
This change will allow us to start testing from dev branch rather than our feature branch.
Testing
Ran tests locally to launch 5 successive EBS-backed tasks. All tasks' EBS volume mounts succeed and tasks are started as expected.
New tests cover the changes: yes
Description for the changelog
Bugfixes for EBS Task Attach.
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.