Use docker stats instead of libcontainer #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced May 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Same as #397, but against the right branch...)
Fixes #387
This PR switches our implementation to rely on Docker's stats API rather than libcontainer to parse cgroup location and reading the cgroup files directly.
I re-enabled the old integ tests for telemetry and they seem to be passing (though
TestStatsEngineWithNewContainersseems a touch flaky). However, much more testing is warranted before this is safe to merge, especially across different Docker versions.r? @aaithal @juanrhenals @richardpen