Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ECS interfaces. #4008

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Integrate ECS interfaces. #4008

merged 1 commit into from
Oct 31, 2023

Conversation

RichaGangwar
Copy link
Contributor

Summary

This PR integrates the applicable shared ECS interfaces with agent.

Implementation details

  1. Remove the ECSTaskProtectionSDK interface from ecs-agent/api/interface.go. ECSTaskProtectionSDK interface was moved to [ecs-agent/api/ecs/interface.go] as part of previous commit.
  2. Update the agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/api/generate_mocks.go to remove mock generation forECSTaskProtectionSDK interface.
  3. Integrate the api and mocks for ECSTaskProtectionSDK interface from new location in the agent codebase.

Testing

Uni tested using make test.

New tests cover the changes: No

Description for the changelog

Integrate the applicable shared ECS interfaces with agent.

Does this PR include breaking model changes? If so, Have you added transformation functions?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RichaGangwar RichaGangwar force-pushed the Integrate_FE_Interface branch 2 times, most recently from 1c407e5 to 870ed08 Compare October 31, 2023 01:22
@RichaGangwar RichaGangwar marked this pull request as ready for review October 31, 2023 01:31
@RichaGangwar RichaGangwar requested a review from a team as a code owner October 31, 2023 01:31
@RichaGangwar RichaGangwar merged commit 9bc4f08 into aws:dev Oct 31, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehlim danehlim danehlim approved these changes

@timj-hh timj-hh timj-hh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichaGangwar @danehlim @timj-hh @amazon-ecs-bot