Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple ENI in ecs-agent/ AttachmentStateChange #4019

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

danehlim
Copy link
Contributor

@danehlim danehlim commented Nov 7, 2023

Summary

Update AttachmentStateChange in ecs-agent module to take into account the ENI decoupling from #3969 (since that pull request did not update the AttachmentStateChange type that was added to ecs-agent module as part of #3943).

Implementation details

Same as summary.

Testing

Unit, integration, and functional tests.

New tests cover the changes: no, but existing test modified

Description for the changelog

Decouple ENI in ecs-agent/ AttachmentStateChange

Does this PR include breaking model changes? If so, Have you added transformation functions?
No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim marked this pull request as ready for review November 7, 2023 21:07
@danehlim danehlim requested a review from a team as a code owner November 7, 2023 21:07
Copy link
Contributor

@timj-hh timj-hh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for picking this up!

Copy link
Contributor

@RichaGangwar RichaGangwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the mocks or are we good there?

@danehlim
Copy link
Contributor Author

danehlim commented Nov 8, 2023

@RichaGangwar

Do we need to update the mocks or are we good there?

Thanks for taking a look! No, we should not need to update any mocks here since no interfaces that we generate mocks from were modified. We can also confirm this by running make gogenerate Makefile target and seeing that no diff is produced.

@danehlim danehlim merged commit de3b79e into aws:dev Nov 8, 2023
38 checks passed
@chienhanlin chienhanlin mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants