Set device names while building task network config #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devices names are the names assigned to the interfaces on the host. For ex, eth1. We need to specify what device names should be assigned to each interface when they are being configured by the CNI plugins.
Realmonia
approved these changes
Nov 15, 2023
xxx0624
approved these changes
Nov 15, 2023
tshan2001
pushed a commit
to tshan2001/amazon-ecs-agent
that referenced
this pull request
Nov 17, 2023
* Set device names while building task network config Devices names are the names assigned to the interfaces on the host. For ex, eth1. We need to specify what device names should be assigned to each interface when they are being configured by the CNI plugins.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Devices names are the names assigned to the interfaces on the host. For ex, eth1. We need to specify what device names should be assigned to each interface when they are being configured by the CNI plugins.
Implementation details
The method that builds the task's network config object was modified to also invoke the
setDeviceNamemethod. ThesetDeviceNametakes a map of mac addresses to device name as an argument.Testing
go test -tags unit ./...New tests cover the changes: yes
Description for the changelog
Set device names while building task network config.
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.