Record and emit the timestamp that the last connection was establishe… #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add a new field in the Session struct to record the timestamp of the latest connection to ACS. Also added a method in the struct's interface to retrieve this value.
Implementation details
The newly added field lastConnectedTime is initialized with value
time.Time{}, which is the default zero value for time.Time. It will be updated to the current time instartSessionOnce()to reflect the latest time that a connection to ACS was established.Testing
bot/testlabel has been added to the PR for functional tests.New tests cover the changes:
A new test called
TestGetLastConnectedTime()has been added to/amazon-ecs-agent/ecs-agent/acs/session/session_test.goto test the behavior of the newly added field and interface in the struct.Description for the changelog
Record and emit the timestamp that a connection was established to ACS
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.