Add Firecracker platform implementation in netlib #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds firecracker platform implementation. Specifically this change includes the task network model creation for Firecracker tasks. The logic to configure interfaces will follow in subsequent PRs.
Realmonia
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds firecracker platform implementation to the netlib package. Specifically this
change includes the task network model creation for Firecracker tasks.
The logic to configure interfaces will follow in subsequent PRs.
Implementation details
Added
firecracker_linux.gofile to hold firecracker implementation of the platform APIs.Made minor modifications in the
BuildTaskNetworkConfigurationworkflow to incorporatefirecracker model creation.
Added test case to validate firecracker model creation.
Testing
go test -tags unit ./ecs-agent/...go test -tags unit ./agent/...New tests cover the changes: Yes
Description for the changelog
Add Firecracker platform implementation in netlib
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.