Update task IAM role model to support Single Region Accounts #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yiyuanzzz
changed the title
Realmonia
previously approved these changes
Nov 21, 2023
| @@ -95,7 +95,8 @@ const ( | |||
| "expiration": "2016-03-25T06:17:19.318+0000", | |||
| "roleArn": "r1", | |||
| "secretAccessKey": "secretAccessKey", | |||
| "sessionToken": "token" | |||
| "sessionToken": "token", | |||
| "credentialScope": "scope" | |||
There was a problem hiding this comment.
The indentation seems correct from my end, don't know why it looks weird here
danehlim
reviewed
Nov 22, 2023
Yiyuanzzz
changed the base branch from
feature/SingleRegionAccounts
to
feature/single-region-accounts
Realmonia
approved these changes
Nov 27, 2023
danehlim
approved these changes
Nov 27, 2023
Yiyuanzzz
merged commit cf1c792
into
aws:feature/single-region-accounts
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update task IAM role model to support Single Region Accounts
Implementation details
Update IAM role credentials model passed from ACS to the agent to include the
CredentialScopefield inecs-agent/credentials/manager.goand existing tests. The updated field will be passed through from the agent to the customer application container via the ecs-agent container credentials handler in/ecs-agent/tmds/handlers/v1/credentials_handler.go.CredentialScopewill be return as part of JSON response by credentials handler along with other credentials.Testing
Unit, integration, and functional tests.
New tests cover the changes: no
Description for the changelog
Update task IAM role model
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.