Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerId, networkNameSpace, containerCGroup to ManagedDaemon #4041

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add containerId, networkNameSpace, containerCGroup to ManagedDaemon #4041

merged 1 commit into from
Nov 21, 2023

Conversation

as14692
Copy link
Contributor

@as14692 as14692 commented Nov 21, 2023 •
edited
Loading

Summary

  • This PR adds new attributes to ManagedDaemon
  • containerId
  • containerCGroup
  • networkNameSpace
  • Adds Getter and Setter for attributes needed to create credentials-fetcher managed daemon

Implementation details

  • Adds Getter and Setter for containerId, containerCGroup, networkNameSpace, healthChecks and command to ManagedDaemon

Testing

  • Added unit tests in managed_daemon_test.go

New tests cover the changes: yes

Description for the changelog

  • Feature - Added containerId, containerCGroup, networkNameSpace to ManagedDaemon

Does this PR include breaking model changes? If so, Have you added transformation functions? - no

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@as14692 as14692 requested a review from amogh09 November 21, 2023 17:57
@as14692 as14692 marked this pull request as ready for review November 21, 2023 17:58
@as14692 as14692 requested a review from a team as a code owner November 21, 2023 17:58
@as14692 as14692 merged commit cf1b45c into aws:dev Nov 21, 2023
42 of 43 checks passed
@danehlim danehlim mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fierlion fierlion fierlion approved these changes

@amogh09 amogh09 amogh09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@as14692 @fierlion @amogh09 @amazon-ecs-bot