Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim managed agent reason + add retries for getting instance identity signature #4042

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

danehlim
Copy link
Contributor

@danehlim danehlim commented Nov 21, 2023

Summary

Add two enhancements to ECS client:

  1. Trim managed agent reason to a max of 255 characters
    • This is not strictly required (since currently in practice Agent will not send a reason that exceeds this max), but is more of a safeguard in case Agent sends larger managed agent reasons in the future. For reference, we already have similar trimming logic in place for other "reason" fields such as container reason - we will reuse this logic by defining a reusable function
  2. Add retries with exponential backoff for retrieving instance identity signature
    • This is a proactive measure in case we run into any intermittent upstream issues when retrieving instance identity signature. For reference, we already have similar retry with exponential backoff logic for retrieving instance identity document

Implementation details

Same as above.

Testing

New tests cover the changes: yes (existing test also modified and addresses testing bug)

Description for the changelog

Trim managed agent reason + add retries for getting instance identity signature

Does this PR include breaking model changes? If so, Have you added transformation functions?

No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim marked this pull request as ready for review November 21, 2023 20:08
@danehlim danehlim requested a review from a team as a code owner November 21, 2023 20:08
@danehlim danehlim merged commit 0bab10f into aws:dev Nov 22, 2023
38 checks passed
@danehlim danehlim mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants