Update grpc contract credfetcher #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
force-pushed
the
update_grpc_contract_credfetcher
branch
7 times, most recently
from
57dc6af
to
6859451
Compare
amogh09
reviewed
Nov 29, 2023
saikiranakula-amzn
force-pushed
the
update_grpc_contract_credfetcher
branch
from
72bfdb5
to
a32e88c
Compare
1. Add client contract to credfetcher 2. Add the associated unit tests
saikiranakula-amzn
force-pushed
the
update_grpc_contract_credfetcher
branch
from
c51d783
to
cb872c6
Compare
amogh09
approved these changes
Dec 1, 2023
danehlim
reviewed
Dec 1, 2023
ecs-agent/gmsacredclient/credentialsfetcher/credentialsfetcher_grpc.pb.go
Show resolved
Hide resolved
|
@amogh09 wrote:
+1, this would help a lot for reviewers/future reference |
danehlim
approved these changes
Dec 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added new client contracts to communicate with credentials-fetcher to support gMSA Linux
Implementation details
The changes are to add the client support to have integration with new contracts exposed by credentials-fetcher
Testing
Added unit tests both positive and negative test case for the functionality. Also manually tested ensuring ECS gMSA works as expected
New tests cover the changes:
Description for the changelog
Adding new contracts to credentials-fetcher client to support gMSA linux
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.