Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check in ecs clint library to ensure only non empty values are added to API request. #4044

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

RichaGangwar
Copy link
Contributor

Summary

This PR adds the check in ecs clint library to ensure only non empty values are added to API request.

Implementation details

  1. Added empty string check for client.configAccessor.OSFamily() as this is an optional field for one of the users of the ecs client shared library.
  2. Added empty string check for client.configAccessor.OSType() as a safety to ensure any future users who have this field as optional would not hit the issue of passing empty value.

Testing

Unit tested
New tests cover the changes: NA

Description for the changelog

Add check in ecs clint library to ensure only non empty values are added to API request.

Does this PR include breaking model changes? If so, Have you added transformation functions?

No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RichaGangwar RichaGangwar marked this pull request as ready for review November 27, 2023 21:54
@RichaGangwar RichaGangwar requested a review from a team as a code owner November 27, 2023 21:54
@RichaGangwar RichaGangwar merged commit 6e0c160 into aws:dev Nov 28, 2023
36 checks passed
@danehlim danehlim mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants