Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fsx windows fileserver SSM arn parsing was incorrect #4058

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

arun-annamalai
Copy link
Contributor

Currently the parsing of the ssm parameter name in the fsx windows file server workflow is incorrect. This is causing customers incorrect behavior when using ssm parameters that have a folder hierarchy.

Summary

This PR is to fix the above bug and allow customers to use ssm parameters that have a folder hierarchy.

Implementation details

Testing

Unit Tests

New tests cover the changes: yes

Description for the changelog

Bug: fsx windows fileserver SSM arn parsing was incorrect

Does this PR include breaking model changes? If so, Have you added transformation functions?

No model changes

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

yinyic
yinyic previously approved these changes Dec 14, 2023
@arun-annamalai
Copy link
Contributor Author

Will be posting integ test results here when completed.

@jiuchoe4
Copy link
Contributor

Integ test results: successfully reproduced the issue wherein task with FSx using SSM parameter for credentials fails with Invalid parameters: fsxwhen the parameter has a path. Also verified that using a parameter without a path worked successfully. Pulled and built this commit, then initialized the new agent on the instance and reran the task with a successful run

amogh09
amogh09 previously approved these changes Dec 15, 2023
@arun-annamalai arun-annamalai merged commit 78e8187 into aws:dev Dec 22, 2023
36 checks passed
@mye956 mye956 mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants