Add ECSClientFactory to create new ECS clients #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
force-pushed
the
ecs-client-factory
branch
from
72d622e
to
fbb39ae
Compare
timj-hh
reviewed
Dec 20, 2023
timj-hh
previously approved these changes
Dec 20, 2023
mye956
reviewed
Dec 21, 2023
mye956
reviewed
Dec 21, 2023
danehlim
force-pushed
the
ecs-client-factory
branch
from
fbb39ae
to
b2c148f
Compare
danehlim
force-pushed
the
ecs-client-factory
branch
from
b2c148f
to
c4ac4f6
Compare
mye956
approved these changes
Dec 21, 2023
timj-hh
approved these changes
Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small "nice to have" change to add an
ECSClientFactoryinterface (and implementing structecsClientFactory) whose purpose is to create/initialize new ECS clients.This can help with testing in other code packages for any future tests we may want to add since it allows us to easily test and define what to expect during other packages' creation of ECS client/how the ECS client came to be in the first place.
Implementation details
ECSClientFactoryinterface to ecs-agent module and use it to create/initialize ECS client in agent moduleECSClientFactoryinterfaceTesting
New tests cover the changes: yes
Description for the changelog
Add ECSClientFactory to create new ECS clients
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.