Bug: Windows numCPU returning incorrectly for values above 64 #4067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a customer issue wherein Windows contiainer instances with vCPU larger than 64 were reporting incorrect CPU values.
Implementation details
The changes are implemented by using MSFT win32 API to get the correct number of CPUs on the instance.
Testing
This was tested by launching an EC2 instance with 128 vCPU and ensuring that the ECS console showed the right CPU count in the resources section.
New tests cover the changes:
yes, there are unit tests added.
Description for the changelog
Bug: Windows numCPU returning incorrectly for values above 64
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.