Fix netns model creation issue #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An nil pointer exception was noticed when a customer specified multi-ENI v1 type task but also included ENI names in their run task call. Added a fix and corresponding unit test for the case.
xxx0624
approved these changes
Jan 20, 2024
xxx0624
reviewed
Jan 20, 2024
tshan2001
approved these changes
Jan 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the creation of network namespace models for AWSVPC mode tasks which causes the agent to crash in an edge case situation.
Implementation details
This change the condition which decides if the task requires a single network namespace or multiple. Previously, presence of ENI names in task payload indicated that the task multiple network namespaces, but we encountered a customer that included ENI names in the run task API for single netns tasks. This change also checks container's interface names to make the decision.
Testing
Manually verified tasks start successful with the fix.
Added tests
New tests cover the changes:
Yes
Description for the changelog
Fixes a bug in the creation of network namespace models for AWSVPC mode tasks which causes the agent to crash in an edge case situation.
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.