Create DNS files for second ENI #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On firecracker, DNS files have to be created for second task ENI.
ohsoo
approved these changes
Feb 1, 2024
Yiyuanzzz
pushed a commit
that referenced
this pull request
Feb 20, 2024
On firecracker, DNS files have to be created for second task ENI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On firecracker, DNS files have to be created for second task ENI.
Implementation details
Modified CreateDNSConfig method in firecracker platform implementation files.
Testing
Manually launched tasks that uses geneve interface and veth interface.
New tests cover the changes:
Yes
Description for the changelog
On firecracker, DNS files have to be created for second task ENI.
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.