Use ECS_EBSTA_SUPPORTED env variable to add EBSTA capabilities #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinyic
previously approved these changes
Feb 9, 2024
chienhanlin
previously approved these changes
Feb 9, 2024
sparrc
reviewed
Feb 9, 2024
ecs-init/engine/engine.go
Outdated
| if err != nil { | ||
| return engineError("could not create EBS mount directory", err) | ||
| // Skip for External, EBS Task Attach is not supported for External launch type | ||
| if !config.RunningInExternal() { |
There was a problem hiding this comment.
This bug affects EC2 launch type too doesn't it? I am wondering if we should just log the failure and continue. Can we disable the EBS capability if we fail to create this directory?
There was a problem hiding this comment.
Also, when running in external we're going to advertise the capability anyways here? even though we failed to make the mnt directory?
prateekchaudhry
dismissed stale reviews from chienhanlin and yinyic
via
c0d1de7
prateekchaudhry
force-pushed
the
ebs-external-dir-fix
branch
2 times, most recently
from
90513fe
to
43f374f
Compare
prateekchaudhry
changed the title
prateekchaudhry
force-pushed
the
ebs-external-dir-fix
branch
2 times, most recently
from
bf779d4
to
d8b7b9c
Compare
prateekchaudhry
force-pushed
the
ebs-external-dir-fix
branch
from
d8b7b9c
to
4016522
Compare
sparrc
approved these changes
Feb 22, 2024
singholt
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for issue #4089
As part of ecs-init start up, init tries to create
/mnt/ecs/ebsdirectory. However depending on how instances are configured,/mntcan be sometimes be read only. This leads toecs-agentcontainer failing to be created with following error inecs-initThis PR changes this by adding an environment variable
ECS_EBSTA_SUPPORTEDtoecs-agent. If set to false, agent will not advertise EBSTA capabilities. This works as followsecs-init/engine/engine.go- If the ebs mount directory/mnt/ecs/ebsfails to be created, we log this error inpre-startand continueecs-init/docker/docker.go- Detect if ebs mount directory has been successfully created. If not set an environment variableECS_EBSTA_SUPPORTEDasfalse(Set defaulttrue)agent/app/agent_capability.go- Check the value ofECS_EBSTA_SUPPORTEDand do not add EBSTA capabilities if the env var is set false. This is set as needed by theecs-initchanges. Agent defaults this totruefor compatibility with olderecs-initversionsTesting
New tests cover the changes:
No new tests added
Description for the changelog
Bugfix: Use
ECS_EBSTA_SUPPORTEDenv variable to add EBSTA capabilitiesDoes this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.