Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating go module dependencies #4109

Merged
merged 1 commit into from
Mar 13, 2024
Merged

updating go module dependencies #4109

merged 1 commit into from
Mar 13, 2024

Conversation

singholt
Copy link
Contributor

@singholt singholt commented Mar 11, 2024

Summary

This PR updates go module dependencies in agent/, ecs-agent/, ecs-agent/daemonimages/csidriver/, and ecs-init/.

Currently, we have 10 open dependabot PRs that are failing PR workflow checks for different reasons. This PR fixes such issues and updates the dependency versions.

The following dependencies have been updated:

  1. go.etcd.io/bbolt from 1.3.6 to 1.3.9 in /agent
  2. github.com/docker/docker from 23.0.3+incompatible to 23.0.8+incompatible in /ecs-init
  3. github.com/containerd/containerd from 1.6.18 to 1.6.26
  4. github.com/docker/docker from 24.0.6+incompatible to 24.0.7+incompatible in /ecs-agent
  5. github.com/docker/docker from 24.0.6+incompatible to 24.0.7+incompatible in /agent
  6. google.golang.org/grpc from 1.53.0 to 1.56.3 in /ecs-agent
  7. google.golang.org/grpc from 1.58.1 to 1.58.3 in /ecs-agent/daemonimages/csidriver
  8. golang.org/x/net from 0.13.0 to 0.17.0 in /ecs-agent
  9. golang.org/x/net from 0.13.0 to 0.17.0 in /ecs-agent/daemonimages/csidriver
  10. github.com/stretchr/testify from 1.8.2 to 1.8.4 in /ecs-agent

Implementation details

  1. Update the required dependency versions, by referring to the open dependabot PRs.
  2. Update the Makefile goimports target to exclude vendor directory inside ecs-agent/daemonimages/csidriver/. This is to address static checks failures.
  3. go mod tidy && go mod vendor in all modules that were touched.

Testing

New tests cover the changes: no

Description for the changelog

enhancement: update go module dependencies

Does this PR include breaking model changes? If so, Have you added transformation functions?

no

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@singholt singholt changed the title Go mod update [wip] Mar 11, 2024
@singholt singholt changed the base branch from master to dev March 11, 2024 18:23
@singholt singholt force-pushed the go-mod-update branch 2 times, most recently from 32935b5 to ee841bf Compare March 11, 2024 18:29
@singholt
Copy link
Contributor Author

singholt commented Mar 11, 2024

The al1 integ test is failing due to a flaky test TestExecCommandAgent. This is a known issue and will need to be looked at outside of this PR.

It is also not marked as "required" for merging the PR currently, so not an immediate blocker.

@singholt singholt marked this pull request as ready for review March 11, 2024 22:15
@singholt singholt requested a review from a team as a code owner March 11, 2024 22:15
@singholt singholt changed the title [wip] updating go module dependencies Mar 11, 2024
@singholt singholt deleted the go-mod-update branch March 13, 2024 18:27
@mye956 mye956 mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants