Explicitly set up ECS config dir in spec files #4131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly make sure that ECS config directory (e.g.,
/etc/ecs
) is created and owned byecs-init
package whenecs-init
package is installed.Current behavior is that this directory is created implicitly elsewhere and not owned by
ecs-init
, which should not be the case.Implementation details
Ensure
%dir %{_sysconfdir}/ecs
is present under%files
section in spec files.Testing
Run the following commands on an EC2 instance to build and install ecs-init RPM package with the changes from this pull request:
Then confirm that ECS config directory is set up correctly and owned by ecs-init:
Also ran automated unit, integration, and functional tests.
New tests cover the changes: no
Description for the changelog
Explicitly set up ECS config dir in spec files
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.