Container Restart Policy ACS model #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
approved these changes
May 14, 2024
danehlim
approved these changes
May 14, 2024
Merged
jiuchoe4
pushed a commit
to saurabhc123/amazon-ecs-agent
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Container Restart Policy ACS model to simply
RestartPolicy, and removeRestartPolicy.RestartPolicyhas no current or future use so it is safe to replace.Implementation details
Ran
make get-deps && make gogenerateinamazon-ecs-agent. Rango mod tidy && go mod vendorin agent module.Testing
Verified that consumer marshals correctly into a
RestartPolicystruct.Description for the changelog
Update ACS model restart policy in ecs-agent
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.