added the implementation for IsBlockDevice method in CSI Driver for Windows #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indows Presently, we were using the empty implementation of the IsBlockDevice method for Windows. In this change, we will add the same. In order to accomplish the same, we use `GetVolumeNameForVolumeMountPointW` Win32 API. Reference: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getvolumenameforvolumemountpointw We will call the API to fetch the Volume GUID. If the mount path is invalid, this method would fail and therefore, we can be certain that the mount path is not the block device mount path.
This change adds `golang.org/x/sys/windows` dependencies as vendor dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Presently, we were using the empty implementation of the IsBlockDevice method for Windows. In this change, we will add the same.
In order to accomplish the same, we use
GetVolumeNameForVolumeMountPointWWin32 API. Reference: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getvolumenameforvolumemountpointwWe will call the API to fetch the Volume GUID. If the mount path is invalid, this method would fail and therefore, we can be certain that the mount path is not the block device mount path.
Implementation details
Added the implementation to invoke Win32 API for
GetVolumeNameForVolumeMountPointWto figure out if the device is block device or not. Also, since the implementation depended upongolang.org/x/sys/windows, the same were vendor'ed in.Testing
A sample binary was created with the same changes as the method implementation in this PR. That was tested for block and non-block devices.
New tests cover the changes: Yes
Description for the changelog
added the implementation for IsBlockDevice method in CSI Driver for Windows
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.