Fix restartAttemptPeriod comparison in restart tracker #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
sparrc
approved these changes
Jul 3, 2024
sparrc
approved these changes
Jul 3, 2024
JoseVillalta
approved these changes
Jul 3, 2024
jiuchoe4
pushed a commit
to saurabhc123/amazon-ecs-agent
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a bug with the restart tracker whereby nanosecond time.Durations were being compared to the restartAttemptPeriod in seconds.
Implementation details
Very quick container exits seem to allow for a situation where the restartAttemptPeriod appears elapsed, even if it is not. Instead of comparing two time.Duration objects we can compare the float64 seconds representation of the elapsed exit time to our reset attempt period.
Testing
make testNew tests cover the changes:
Description for the changelog
Fix restartAttemptPeriod comparison in ecs-agent restart tracker
Does this PR include breaking model changes? If so, Have you added transformation functions?
no
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.