exclude cache value from container memory utilization metric #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #280 by excluding cache usage from memory utilization stat.
Implementation details
Subtract MemoryStats.Stats.Cache from MemoryStats.Usage and use the result as the memory stat.
Testing
I have not been able to get the test suite to run successfully on master/dev or on the fork. I'm new to go, so guessing this is an issue with my local configuration 😅 A few things that I've been able to test successfully:
I'm happy to keep trying to get the suite to run if this is a prerequisite for a PR, but would really appreciate some pointers on how to get tests running in a fresh environment (any gotchas with versioning/dependencies?)
make release
)make short-test
) passmake test
andmake run-integ-tests
) passmake run-functional-tests
) passNew tests cover the changes: Yes
Description for the changelog
Fix memory metric to exclude cache value.
Licensing
This contribution is under the terms of the Apache 2.0 License: Yes