Support Logentries Log Driver #870
Conversation
|
Integration and functional tests fail to build, so can't execute. |
There was a problem hiding this comment.
Thanks for sending this! I believe we need a somewhat larger change to actually make this (I don't think the logentries driver will actually register because the 1.25 API version is not "supported"), but I've gone ahead and made the logic change in #875.
| @@ -961,7 +961,8 @@ | |||
| "journald", | |||
| "gelf", | |||
| "fluentd", | |||
| "awslogs" | |||
| "awslogs", | |||
| "logentries" | |||
There was a problem hiding this comment.
Can you undo the change here? This file is generated from a different one we have internally. Once we get this merged, I can make the change internally.
agent/ecs_client/model/ecs/api.go
Outdated
| @@ -7479,6 +7479,9 @@ const ( | |||
|
|
|||
| // LogDriverAwslogs is a LogDriver enum value | |||
| LogDriverAwslogs = "awslogs" | |||
|
|
|||
| // LogDriverLogentries is a LogDriver enum value | |||
| LogDriverLogentries = "logentries" | |||
|
changes successfully validated on a clean container instance using a Logentries trial account. |
|
Have people been experiencing an issue with this Driver? We've had problems for several months with containers seemingly stopping logging to LE. It seems consistent on only ECS containers using the driver (different apps, too). We've had to switch to awslog driver / app logging with some forwarding for out-of-app stuff :/ we are still trying to troubleshoot the issue |
Summary
Adding support for Logentries log driver introduced in docker API 1.25 (docker version 1.13.0).
Implementation details
Adding logger names to appropriate places.
Testing
Tested on newest AWS Linux ECS by replacing the stock image with this one, updating
ECS_AVAILABLE_LOGGING_DRIVERSvariable, and scheduling a task withlogentrieslog driver configured.make release)go build -out amazon-ecs-agent.exe ./agent)make test-in-docker) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: no
Description for the changelog
Support Logentries Log Driver
Licensing
This contribution is under the terms of the Apache 2.0 License: yes