fix the memory leak in event handler #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaithal
reviewed
Sep 6, 2017
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## UNRELEASED | |||
| * Feature - Support for provisioning Tasks with ENIs | |||
| * Bug - Fixed an memory leak issue | |||
There was a problem hiding this comment.
Can you please add more details here? "Fixed a memory leak issue when ..."
agent/eventhandler/task_handler.go
Outdated
| // Prepares a given event to be sent by adding it to the handler's appropriate | ||
| // eventList | ||
| // addEvent prepares a given event to be sent by adding it to the handler's appropriate | ||
| // eventList and remove the entry in tasksToEvents map | ||
| func (handler *TaskHandler) addEvent(change *sendableEvent, client api.ECSClient) { | ||
| seelog.Info("TaskHandler, Adding event: ", change) |
There was a problem hiding this comment.
Can you move this below the taskHandlerLock statements? Also, you can change it to use Infof while you're here.
richardpen
force-pushed
the
issue-798
branch
from
6224c39
to
bc33c22
Compare
aaithal
approved these changes
Sep 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix the memory leak in event handler, #798
Implementation details
Remove the entry in the map after calling sumbitstatechange.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
yes
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License:
yes