Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

ECS now supports cgroups v2 #503

Merged
merged 1 commit into from
May 3, 2022
Merged

ECS now supports cgroups v2 #503

merged 1 commit into from
May 3, 2022

Conversation

fendent
Copy link
Contributor

@fendent fendent commented Apr 21, 2022

Summary

ECS now supports cgroups v2 and no longer needs to block the install in this case.

Reference:
aws/containers-roadmap#1535
aws/amazon-ecs-agent#3127

Implementation details

I removed the flow logic that bails if it detects cgroups v2.

Testing

I have been able to successfully run the install script and get a properly running ECS agent in docker on a cgroups v2 debian bullseye docker container.

New tests cover the changes: no

Description for the changelog

Bug - Install script no longer fails on systems using cgroups v2

Licensing

This contribution is under the terms of the Apache 2.0 License: yes

@fendent
Copy link
Contributor Author

fendent commented Apr 21, 2022

Will changes made to ecs-anwyhere-install.sh in this repo reflect on the script in the public S3 bucket that the ECS console has you use to register external instances?

@sparrc
Copy link
Contributor

sparrc commented Apr 21, 2022

Will changes made to ecs-anwyhere-install.sh in this repo reflect on the script in the public S3 bucket that the ECS console has you use to register external instances?

Yep! it will be updated after our next ecs agent/init release, which should happen within 2-4 weeks

Copy link
Contributor

@sparrc sparrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants