Fix manifests and Makefile for v0.3.0 #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3poteto
commented
Feb 11, 2022
| - kind: ServiceAccount | ||
| name: pod-identity-webhook | ||
| namespace: default | ||
| --- |
There was a problem hiding this comment.
When --in-cluster=false, we don't need this role. Because this webhook no longer creates a secret. The secret will be created by cert-manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This pull request is related to #139 and #134.
Description of changes:
After v0.3.0,
--in-ncluster=trueoption does not work fine. But Makefile was supposed to use CSR, so I could not install manifests using Makefile. I change manifests and Makefile to not use CSR.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.