Update in-cluster installation make target #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekgogia
reviewed
Jun 8, 2022
| @@ -72,20 +72,13 @@ cluster-down: delete-config | |||
| prep-config: | |||
| @echo 'Generating certs and deploying into active cluster...' | |||
| cat deploy/deployment-base.yaml | sed -e "s|IMAGE|${IMAGE}|g" | tee deploy/deployment.yaml | |||
| cat deploy/mutatingwebhook.yaml | hack/webhook-patch-ca-bundle.sh > deploy/mutatingwebhook-ca-bundle.yaml | |||
There was a problem hiding this comment.
deploy/mutatingwebhook-ca-bundle.yaml is also referenced below in the delete-config step, do we need to update there as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #144
Description of changes:
This previous PR changed the pod-identity-webhook deployment to use cert-manager instead of CSR, and set the in-cluster flag to false by default. With these changes, the CSR never gets created as its not required.
However the make target for the self hosted installation keeps waiting for CSR to be created. This PR removes that wait. It also removes the line that updates the mutating webhook manifest since that's not needed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.