add check for SA to client if not found in cache #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsilverio22
force-pushed
the
irsa
branch
3 times, most recently
from
f9c24cd
to
704b51c
Compare
Signed-off-by: Joshua Silverio <joshua@acorn.io>
|
@jsilverio22 We're encountering this issue in our clusters and wondering if this fix could get merged. Have you heard from any maintainers on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#174
Description of changes:
Trying to solve a race condition in aws-identity pod where serviceaccount and pod get created at the same time. It uses cache to check SA which might not be ready when the pod was created. In order to solve this if a SA is not found in the cache but is expected do not allow the request through so it gets retried later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.