Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify healthcheck endpoint port with application port #229

Merged

Conversation

modulitos
Copy link
Contributor

@modulitos modulitos commented Jul 2, 2024

Description of changes:

Unify healthz and service port for both the traffic to be served on the same port. Prevents issues where pod is considered healthy but not serving any requests.

Testing:

# start server via "make clean && make local-serve", then:

❯ curl -k -i https://localhost:8443/healthz
HTTP/2 200
content-type: text/plain; charset=utf-8
content-length: 2
date: Tue, 02 Jul 2024 00:17:44 GMT

ok

@modulitos modulitos requested a review from a team as a code owner July 2, 2024 00:14
@kmala kmala merged commit 88006e0 into aws:master Jul 3, 2024
1 check passed
@jackchi
Copy link

jackchi commented Jul 22, 2024

What should the port be now?

The deployment I had for this is now failing.

readinessProbe:
            httpGet:
              path: /healthz
              port: metrics
              scheme: HTTP

@kmala
Copy link
Contributor

kmala commented Jul 23, 2024

Until v0.5.5 release you shouldn't face issue as the healthz is responding on both the ports. If you using changes from master, then you should use the application port, not sure what is the name you had given for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants