Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If PutRecords partially fails, retry failed record only #31

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from

Conversation

teryaev
Copy link

@teryaev teryaev commented Jun 16, 2020

Changes released in #27 cause a bug with retrying partially failed PutRecords requests: in cases where PutRecords fails for a part of sent records, all the records are retried including successfully flushed ones.

Description of changes:
This change handles cases where PutRecords fails to process a part of records. Only failed records should be retried.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

teryaev added 2 commits June 16, 2020 22:24
…esponse; exclude succefully put records from list of records to flush
@PettitWesley PettitWesley changed the base branch from master to mainline June 19, 2020 16:26
@PettitWesley
Copy link
Contributor

@teryaev This needs to be rebased. I'm pretty sure though that part of the change in #33 fixed this issue.

Even if that's the case, adding your unit test would be nice- please rebase so we can add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants