fix(fig_desktop): exit code not propagated by main #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant0417
force-pushed
the
fix-exit-code
branch
2 times, most recently
from
9b753d2 to
5931abd
Compare
This fixes an issues that was accidently introduced in 524eec6. To prevent this again I have marked the functions in the file as `#[must_use]`.
grant0417
force-pushed
the
fix-exit-code
branch
from
5931abd to
a83f257
Compare
grant0417
changed the title
grant0417
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 12.43% 12.43%
=======================================
Files 2233 2233
Lines 189905 189902 -3
Branches 174493 174490 -3
=======================================
Hits 23608 23608
+ Misses 165116 165113 -3
Partials 1181 1181 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issues that was accidently introduced in #394. To prevent this again I have marked the functions in the file as
#[must_use].By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.