Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.7.3 with TCP early demux toggle #1220

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Sep 16, 2020

What type of PR is this?
bug fix, documentation, config

Which issue does this PR fix:
#1212

What does this PR do / Why do we need it:
For kubelet to be able to talk to pods using security groups on the same node using TCP, we need to disable the TCP early demux.

Testing done on this change:
Perfomance tests and invistigations in #1212.

Automation added to e2e:
None

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:
Yes, we now have the flag DISABLE_TCP_EARLY_DEMUX to the cni-init container.

Does this PR introduce any user-facing change?:
Yes, a new environment variable

Release-notes have been updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested a review from haouc September 16, 2020 21:45
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@SaranBalaji90 SaranBalaji90 merged commit 1412208 into aws:release-1.7 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants