Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to controller-runtime 1.15 #260

Closed
wants to merge 2 commits into from

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jun 7, 2023

Issue #, if available:

Description of changes:

Upgrade to controller-runtime 1.15 for kubernetes-sigs/controller-runtime#2116, which will help with startup latency when operators like Crossplane are installed.

❯ make test
/Users/etarn/go/bin/controller-gen object:headerFile="scripts/templates/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
/Users/etarn/go/bin/controller-gen "crd:trivialVersions=true" rbac:roleName=controller-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
go test ./pkg/... ./controllers/... ./webhooks/... -coverprofile cover.out
?   	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/api	[no test files]
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/aws/ec2	0.381s	coverage: 85.2% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/aws/ec2/api	0.710s	coverage: 43.6% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/aws/vpc	0.891s	coverage: [no statements]
?   	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider	[no test files]
?   	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/version	[no test files]
?   	github.com/aws/amazon-vpc-resource-controller-k8s/controllers/custom	[no test files]
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/condition	22.914s	coverage: 63.3% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/config	0.362s	coverage: 87.5% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/handler	1.191s	coverage: 69.0% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/healthz	15.373s	coverage: 57.1% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/k8s	1.853s	coverage: 57.4% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/k8s/pod	1.717s	coverage: 53.5% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/node	1.654s	coverage: 91.5% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/node/manager	1.001s	coverage: 84.5% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/pool	1.188s	coverage: 96.3% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/branch	0.928s	coverage: 56.4% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/branch/trunk	0.735s	coverage: 88.3% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/ip	0.866s	coverage: 50.3% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/provider/ip/eni	0.656s	coverage: 92.9% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/resource	0.656s	coverage: 72.2% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/utils	6.043s	coverage: 78.9% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/pkg/worker	0.930s	coverage: 81.5% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/controllers/apps	0.573s	coverage: 78.6% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/controllers/core	15.767s	coverage: 68.2% of statements
ok  	github.com/aws/amazon-vpc-resource-controller-k8s/webhooks/core	0.376s	coverage: 83.0% of statements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdn5126
Copy link
Contributor

jdn5126 commented Jun 7, 2023

Compilation changes look good, but we definitely want some targeted integration test runs in this area. @haouc what is the best way to go about this?

@ellistarn ellistarn changed the title [EXPERIMENTAL] chore: Upgrade to controller-runtime 1.15 chore: Upgrade to controller-runtime 1.15 Aug 1, 2023
@ellistarn
Copy link
Contributor Author

Closing in favor of handing off to @jaydeokar #286

@ellistarn ellistarn closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants