Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to kubebuilder v3 #369

Merged
merged 1 commit into from
Feb 6, 2024
Merged

chore: migrate to kubebuilder v3 #369

merged 1 commit into from
Feb 6, 2024

Conversation

sushrk
Copy link
Contributor

@sushrk sushrk commented Feb 6, 2024 •
edited

Issue #, if available:
#199
Description of changes:
go/v2 is deprecated, https://book.kubebuilder.io/plugins/go-v2-plugin

Migrate project to kubebuilder v3, reference https://book.kubebuilder.io/migration/legacy/manually_migration_guide_v2_v3

Integration test looks good:

Ran 19 of 23 Specs in 1640.744 seconds
SUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 4 Skipped
PASS

Ginkgo ran 1 suite in 27m22.962920062s
Test Suite Passed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sushrk sushrk requested a review from a team as a code owner February 6, 2024 20:19
haouc
haouc approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sushrk sushrk merged commit 18352ea into aws:master Feb 6, 2024
3 checks passed
@sushrk sushrk linked an issue Feb 6, 2024 that may be closed by this pull request
Newer controller-gen doesn't correctly recognize markers. Need upgrade. #199
Open
@sushrk sushrk mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haouc haouc haouc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer controller-gen doesn't correctly recognize markers. Need upgrade.
2 participants
@sushrk @haouc