Record: Handle Kernel config not available #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| _ => match os_error.raw_os_error().unwrap() { | ||
| libc::EMFILE => error!( | ||
| "Too many open files. Increase limit with `ulimit -n`" | ||
| libc::EMFILE => warn!( |
There was a problem hiding this comment.
Wouldn't this be needed for any basic collection to work in APerf? So, this has to be an error and not warning?
There was a problem hiding this comment.
It doesn't prevent APerf from running.
| @@ -6,7 +6,7 @@ use crate::{PERFORMANCE_DATA, VISUALIZATION_DATA}; | |||
| use anyhow::Result; | |||
| use chrono::prelude::*; | |||
| use ctor::ctor; | |||
| use log::{error, trace}; | |||
| use log::{trace, warn}; | |||
There was a problem hiding this comment.
In general, can we summarize what all are not collected (for which warnings are issued) when requirements are not met and a message is dumped to console or a file/ log?
wash-amzn
reviewed
Nov 29, 2023
src/data/systeminfo.rs
Outdated
| @@ -121,7 +121,17 @@ impl CollectData for SystemInfo { | |||
|
|
|||
| match rt.block_on(EC2Metadata::get_instance_metadata()) { | |||
| Ok(s) => self.set_instance_metadata(s), | |||
| Err(e) => error!("An error occurred: {}", e), | |||
| Err(e) => { | |||
| warn!("An error occurred: {}", e); | |||
There was a problem hiding this comment.
What is it, a warning or an error? :p
"Unable to get instance metadata: {}" would be more meaningful since there isn't going to be much context to understand what was being attempted when the failure is reported.
Also, * use WARN in Perf Stat when asking to change system settings. * use WARN in SystemInfo when IMDS fails.
wash-amzn
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.