Use sysconf to get the total online CPUs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
num_cpus does not return the total number of CPUs if aperf is taskset. Use sysconf to get the total number of online CPUs.
|
Do you have a reproducible example of this problem? I never ran into it. |
|
The bigger problem to solve here is the report of failures when the set of disabled CPUs isn't contiguous and at the end of the CPU list. |
Run aperf with taskset. Ex: |
That is not my experience. I was doing many runs with taskset and aperf recorded all CPUs normally. |
wash-amzn
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_cpus does not return the total number of CPUs if aperf is taskset. Use sysconf to get the total number of online CPUs.
compare.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.