Add support for selecting CPU(s) #203
Conversation
|
When "All" isn't selected, aggregate graphs (PMU Stats tab) should also be disabled. |
src/html_files/interrupts.ts
Outdated
| name: `CPU ${cpu}`, | ||
| x: x_time, | ||
| y: y_data, | ||
| type: 'scatter', | ||
| }; | ||
| if (interrupt_cpu_list.get(run).indexOf(cpu.toString()) == -1) { |
There was a problem hiding this comment.
Up in cpu_utilization you toString the cpu variable earlier.
If you're going to have repeated code like this (which ideally would be avoided), at least keep it consistent.
But really, try to find ways to extract out things like this which look identical, or almost identical, across multiple data types.
There was a problem hiding this comment.
This is due to the different way data is packaged. Also, we wanted to avoid checking for 'Aggregate' in multiple places.
| grid-column: 1; | ||
| } | ||
|
|
||
| .configure { |
There was a problem hiding this comment.
This matches a class, but you've named the button configure in index.html. That's why this background image isn't showing up. When you fix that, you'll see the issue with its position.
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>APerf</title> | ||
| </head> | ||
| <body> | ||
| <div class="tab"> | ||
| <div class="aperf">APerf</div> | ||
| <button class="tablinks" name="configure"><div class="icon-text">Configure</div><div class="configure"/></button> |
There was a problem hiding this comment.
Can you try to make this look different? Perhaps when the settings icon is working that will help, but I'm thinking of making it obviously not a peer to the other tabs which are data types.
| @@ -199,6 +199,7 @@ pub fn report(report: &Report) -> Result<()> { | |||
|
|
|||
| info!("Creating APerf report..."); | |||
| let ico = include_bytes!("html_files/favicon.ico"); | |||
| let configure = include_bytes!("html_files/configure.png"); | |||
There was a problem hiding this comment.
I don't think this is used.
There was a problem hiding this comment.
Nevermind, I see where it's used now. Multiple variables with similar names.
This will allow the user to select the CPU(s) for all the graphs in CPU Utilization, Perf Stat and Interrupt tabs.
This will allow the user to select the CPU(s) for all the graphs in CPU Utilization, Perf Stat and Interrupt tabs.
icocpus.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.