Create a tmp directory for record and report #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, move to using references where possible for the Data trait.
janaknat
force-pushed
the
tmp-dir-update
branch
from
bb815df
to
3c703a9
Compare
wash-amzn
reviewed
Sep 12, 2024
| let tmp_dir = TempBuilder::new() | ||
| .prefix("aperf-tmp-") | ||
| .tempdir_in(&cli.tmp_dir)?; | ||
| fs::set_permissions(&tmp_dir, fs::Permissions::from_mode(0o1777))?; |
There was a problem hiding this comment.
The previous code was setting only 0o777, not 0o1777. Technically the 1 seems right for a directory, but it wasn't necessary before. Did something change, or did you notice some problem with what was happening before?
There was a problem hiding this comment.
The 1 sets the sticky bit which is required to prevent users who have access to this dir from deleting the dir.
wash-amzn
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the TempDir crate to generate unique temp directories for aperf runs. Also, move to using references where possible for the Data trait.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.