Update raw interrupt processing #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash-amzn
reviewed
Feb 22, 2023
janaknat
force-pushed
the
interrupt_fix
branch
from
15985f3
to
a6ea377
Compare
In some cases, interrupt lines don't have the whitespace as aperf is expecting. Change the split logic to look at whitespaces and ':'. Also, update the visualizer to explicitly check for Err instead of unwrapping().
janaknat
force-pushed
the
interrupt_fix
branch
from
a6ea377
to
2654e8b
Compare
Ok. I've added a test with that data. |
wash-amzn
reviewed
Feb 22, 2023
| InterruptDataRaw: | ||
| time: | ||
| DateTime: "2022-01-01T01:01:01.000000000Z" | ||
| data: " CPU0 CPU1 CPU2 CPU3 CPU4 CPU5 CPU6 CPU7 \n 123:0 0 0 0 0 0 0 0 PCI edge device\n" |
There was a problem hiding this comment.
The original issue was related to IPI, what part of this test data verifies a fix for the original problem?
There was a problem hiding this comment.
The problem surfaced with IPI. The underlying issue was aperf was expecting a space after ':'.
wash-amzn
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, interrupt lines don't have the whitespace as aperf is expecting. Change the split logic to look at whitespaces and ':'. Also, update the visualizer to explicitly check for Err instead of unwrapping().
Ex:
Previously, aperf was expecting:
In cases where it is:
aperf raw interrupt processing fails. To avoid this use ':' in addition to whitespaces to look for the INTR line.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.