Visualizer updates #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash-amzn
reviewed
Mar 13, 2023
src/data/constants.rs
Outdated
| @@ -2,3 +2,5 @@ pub static KB_FACTOR: u64 = 1024; | |||
| pub static MB_FACTOR: u64 = 1048576; | |||
| pub static TIME_S_FACTOR: u64 = 1000; | |||
| pub static FACTOR_OF_ONE: u64 = 1; | |||
| pub static MULT_FACTOR: u64 = 1; | |||
| pub static SECTORS: u64 = 512; | |||
There was a problem hiding this comment.
That name is pretty vague.
There was a problem hiding this comment.
Darnit, I know why two lines got selected ..... yes I mean SECTORS
Comment on lines
+228
to
+230
| if unit == "MB" { | ||
| factor = MB_FACTOR; | ||
| } |
There was a problem hiding this comment.
unit "MB" only occurs for keys that contain "Sectors"???
Updates: * CPU Utilization graph y-axis is always 100%. * Diskstat read, sector graph updates. * VMStat graph updates.
janaknat
force-pushed
the
visualizer_updates
branch
from
05748c5 to
1b9e5ab
Compare
wash-amzn
approved these changes
Mar 14, 2023
| @@ -2,3 +2,5 @@ pub static KB_FACTOR: u64 = 1024; | |||
| pub static MB_FACTOR: u64 = 1048576; | |||
| pub static TIME_S_FACTOR: u64 = 1000; | |||
| pub static FACTOR_OF_ONE: u64 = 1; | |||
| pub static MULT_FACTOR_OF_ONE: u64 = 1; | |||
| pub static MULT_SECTORS: u64 = 512; | |||
There was a problem hiding this comment.
That name is still pretty unhelpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.