Update README.md #75
Merged
Update README.md #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash-amzn
reviewed
Aug 9, 2023
README.md
Outdated
Comment on lines
68
to
71
| To compare the results of two different performance runs, use the following command: | ||
| ``` | ||
| ./aperf-v0.1.4-alpha-aarch64/aperf report --run-directory c7g_performance_run_1 --run-directory c6i_performance_run_1 | ||
| ``` |
There was a problem hiding this comment.
Match the style of the example line above (don't include directory aperf is in and use names for parameter values
There was a problem hiding this comment.
This was taken from the file: https://github.com/aws/aperf/blob/main/EXAMPLE.md to keep it consistent.
There was a problem hiding this comment.
I realize that file has a different convention, but the one in this file is what matters for this change.
There was a problem hiding this comment.
Done. Thank you.
wash-amzn
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added steps to compare two different performance runs.
Reason: README on APerf landing page should highlight that we can compare profile collected from multiple runs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.