Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data availability checks to lib from visualizer #78

Closed
wants to merge 1 commit into from

Conversation

janaknat
Copy link
Contributor

This allows the visualizer to proceed if any data is unavailable. Useful when a newer aperf is used to generate a report from data collected with an older aperf.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@wash-amzn wash-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a set would be better than a map<_, bool>

@janaknat
Copy link
Contributor Author

Using a set would be better than a map<_, bool>

It is easier to use .get for HashMap than looping over a set though.

@janaknat
Copy link
Contributor Author

Using a set would be better than a map<_, bool>

I've changed to use HashSets.

@janaknat janaknat closed this Aug 30, 2023
@janaknat janaknat deleted the backend-update branch September 1, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants